Fix Zarr 'number of requests' test #10492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
I'm still pretty confused as to how this was contaminating relevant between the tests (seemingly zarr_format) but worth noting that "function" is the default scope so we shoudl consider changing the datatree fixture to a smaller scope |
|
Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixess the test test failures introduced by #10469
That PR introduced a new test that used the
time_unitfixture which is scoped tomodule. This was somehow resulting in leakage of state across tests. Normally this doesn't seem to matter (e.g. other fixtures also use that scope) but it was affecting the get/set counting.See also: https://docs.pytest.org/en/stable/how-to/fixtures.html#fixture-scopes
This also reverts: 8d2e563 to restore the initial values
@maxrjones your bisecting was very helpful! also @TomNicholas
whats-new.rstapi.rst