This repository was archived by the owner on Mar 21, 2019. It is now read-only.
Minimize diff with python-ldap, and deprecate pyldap #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unicode literals are not needed here.
One of these is a SyntaxError caused by mis-merge, others are whitespace or naming fixes
(The new wording parallels other comments in the file)
The io module was backported to Python 2.7. It uses the C-optimized version, so cStringIO is not needed either.
Python 2.7 has these built-in
python-ldap has the same code, but without the comments
The patches wil be squashed for python-ldap. Put all authors and a link to the full history in the credits section.
tiran
approved these changes
Nov 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked our changes with respect to python-ldap, and found some that would be better reverted, or otherwise made smaller.
This change also re-brands the project back to python-ldap.
Except the warning in the README, the result is what I'd like to merge into python-ldap.