Skip to content

Use prescriptve description for unidiomatic-typecheck #4305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

DudeNr33
Copy link
Collaborator

@DudeNr33 DudeNr33 commented Apr 6, 2021

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Replace the currently descriptive message for unidiomatic-typecheck (C0123) with a descriptive one as supposed by the author of issue #3891.

Type of Changes

Type
✨ New feature

(Would not really call it a new feature, but the issue is labeled with "enhancement" instead of "bug")

Related Issue

Closes #3891

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.593% when pulling 6b94f03 on DudeNr33:fix-issue-3891 into a47cb27 on PyCQA:master.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that, small change but strangely impactful, thank you.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.7.5 milestone Apr 6, 2021
@Pierre-Sassoulas Pierre-Sassoulas added the Enhancement ✨ Improvement to a component label Apr 6, 2021
@Pierre-Sassoulas Pierre-Sassoulas merged commit c373774 into pylint-dev:master Apr 6, 2021
@DudeNr33 DudeNr33 deleted the fix-issue-3891 branch April 6, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unidiomatic-typecheck has descriptive rather than prescriptive lint message text
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy