Skip to content

gh-62480: Remove first-person usage for some docs #102295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

nw0
Copy link
Contributor

@nw0 nw0 commented Feb 27, 2023

Additionally: clean up the text explanation for one mock example which this commit touches.

In particular I think this addresses the remaining examples in #62480 (comment)

Additionally: clean up the text explanation for one mock example which
this commit touches.
@nw0 nw0 requested review from rhettinger and a team as code owners February 27, 2023 13:28
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Feb 27, 2023
@rhettinger rhettinger removed their request for review March 2, 2023 03:10
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is an improvement. It also introduces a typo

@RafaelWO
Copy link
Contributor

Hey @nw0, do you mind if I pick this up? 🙂

Except if @hauntsaninja thinks it should be closed?

@nw0
Copy link
Contributor Author

nw0 commented Jul 19, 2025

Hey @nw0, do you mind if I pick this up? 🙂

Please do. I'm going to close this PR, as it's not had meaningful feedback.

@nw0 nw0 closed this Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes docs Documentation in the Doc dir skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

7 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy