Skip to content

gh-106368: Increase coverage for Argument Clinic output directive #106979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2023
Merged

gh-106368: Increase coverage for Argument Clinic output directive #106979

merged 2 commits into from
Jul 22, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 21, 2023 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland requested a review from sobolevn July 21, 2023 21:57
@bedevere-bot bedevere-bot mentioned this pull request Jul 21, 2023
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jul 21, 2023
sobolevn
sobolevn approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question is not blocking :)
Thanks!

@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews!

@erlend-aasland erlend-aasland enabled auto-merge (squash) July 22, 2023 09:06
@erlend-aasland erlend-aasland merged commit ee5c01b into python:main Jul 22, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ee5c01b473eeadb007b9f330db3143e34e46038b 3.11

@bedevere-bot
Copy link

GH-106994 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
@erlend-aasland @miss-islington
pythongh-106368: Increase coverage for Argument Clinic output directi…
483c3d6 
…ve (pythonGH-106979)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot
Copy link

GH-107002 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 22, 2023
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 22, 2023
@erlend-aasland @ambv
[3.11] pythongh-106368: Increase coverage for Argument Clinic output …
42dd5ce 
…directive (pythonGH-106979)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 22, 2023
@miss-islington @erlend-aasland
[3.12] gh-106368: Increase coverage for Argument Clinic output direct…
76fd98a 
…ive (GH-106979) (#106994)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@erlend-aasland
Copy link
Contributor Author

I'll fix the backport later, unless someone beats me to it :)

ambv added a commit that referenced this pull request Jul 22, 2023
@ambv @erlend-aasland
[3.11] gh-106368: Increase coverage for Argument Clinic output direct…
06f8a43 
…ive (GH-106979) (#107002)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@erlend-aasland erlend-aasland deleted the clinic/coverage-output-directive branch July 22, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv ambv left review comments

@sobolevn sobolevn sobolevn approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees

@erlend-aasland erlend-aasland

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @miss-islington @bedevere-bot @ambv @sobolevn
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy