Add SynchronizedBase to __all__ #110304
Open
Add SynchronizedBase to __all__ #110304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
Reviewers: I didn't think this needed a GH Issue # b/c it's such a small change. I'm fine with exporting a different class, or masking this differently, but - to me - this seems like something that's obviously necessary. If this shouldn't go in, I'm fine with it not going in. |
Recently I was writing some heavily-parallel code, and I tried to type-check with `mypy`. I (naively) thought that `multiprocessing.Value` was a class and was very confused when `mypy` threw an error on that line. I dropped into the interpreter and tried to use the `help` function to find the return type of `Value` - and failed. I dropped into the code and found that the type returned from the `Value` function was not exported from the module. I want types in Python to be _awesome_. I think `mypy` is a step in the right direction for that. This change is me doing my part to expose more types so `mypy` can become as good as it can be. distortedsignal<distortedsignal@gmail.com>
18ba3f0 to
b58403e
Compare
|
Boop. |
| # Methods for getting synchronization wrappers | ||
| 'Value', 'Array', | ||
| # The synchronization types | ||
| 'Synchronized', 'SynchronizedArray', 'SynchronizedString', |
There was a problem hiding this comment.
These are not documented and therefore not properly public, why should they be added to __all__?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I was writing some heavily-parallel code,
and I tried to type-check with
mypy. I (naively)thought that
multiprocessing.Valuewas a classand was very confused when
mypythrew an erroron that line. I dropped into the interpreter and
tried to use the
helpfunction to find thereturn type of
Value- and failed. I droppedinto the code and found that the type returned
from the
Valuefunction was not exported fromthe module.
I want types in Python to be awesome. I think
mypyis a step in the right direction for that.This change is me doing my part to expose more
types so
mypycan become as good as it can be.