Skip to content

bpo-35647: Fix path check in cookiejar #11436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 10, 2019
Merged

bpo-35647: Fix path check in cookiejar #11436

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77e9c16
Refactor cookie path check as per RFC 6265
tirkarthi Dec 27, 2018
a3478c7
Add tests for prefix match of path
tirkarthi Dec 30, 2018
1e81804
Add news entry
tirkarthi Dec 30, 2018
5dc9237
Fix set_ok_path and refactor tests
tirkarthi Jan 3, 2019
de2c5a4
Use slice for last letter
tirkarthi Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Refactor cookie path check as per RFC 6265
  • Loading branch information
@tirkarthi
tirkarthi committed Jan 16, 2019
commit 77e9c16dca38f9b07e9065fa15e9cab11ce3669d
11 changes: 7 additions & 4 deletions Lib/http/cookiejar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,11 +1190,14 @@ def domain_return_ok(self, domain, request):
def path_return_ok(self, path, request):
_debug("- checking cookie path=%s", path)
req_path = request_path(request)
if not req_path.startswith(path):
_debug(" %s does not path-match %s", req_path, path)
return False
return True
if req_path == path:
return True
elif (req_path.startswith(path) and
(path.endswith("/") or req_path[len(path)] == "/")):
return True

_debug(" %s does not path-match %s", req_path, path)
return False

def vals_sorted_by_key(adict):
keys = sorted(adict.keys())
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy