Apply suggestions from code review

Co-authored-by: Brett Cannon <brett@python.org>
python · barneygale · Jan 30, 2024 · Jan 30, 2024 · Feb 21, 2024 · Feb 21, 2024
commit 1a82b097c0b9cb9d7f4350df3dcdd0ab1a79d6c7
diff --git a/Doc/library/tempfile.rst b/Doc/library/tempfile.rst
@@ -143,7 +143,7 @@ The module defines the following user-callable items:
       Added *delete_on_close* parameter.
 
    .. versionchanged:: 3.13
-      Returns a :term:`path-like object`.
+      Added support for the :term:`path-like object` protocol.
 
 
 .. class:: SpooledTemporaryFile(max_size=0, mode='w+b', buffering=-1, encoding=None, newline=None, suffix=None, prefix=None, dir=None, *, errors=None)
@@ -221,7 +221,7 @@ The module defines the following user-callable items:
       Added the *delete* parameter.
 
    .. versionchanged:: 3.13
-      Returns a :term:`path-like object`.
+      Added support for the :term:`path-like object` protocol.
 
 
 .. function:: mkstemp(suffix=None, prefix=None, dir=None, text=False)

diff --git a/Lib/tempfile.py b/Lib/tempfile.py
@@ -506,9 +506,7 @@ def func_wrapper(*args, **kwargs):
         return a
 
     def __fspath__(self):
-        """
-        Return the filesystem path of this temporary file.
-        """
+        """Return the filesystem path of the temporary file."""
         return self.name
 
     # The underlying __enter__ method returns the wrong object
@@ -945,9 +943,7 @@ def __repr__(self):
         return "<{} {!r}>".format(self.__class__.__name__, self.name)
 
     def __fspath__(self):
-        """
-        Return the filesystem path of this temporary directory.
-        """
+        """Return the filesystem path of the temporary directory."""
         return self.name
 
     def __enter__(self):

diff --git a/Lib/test/test_tempfile.py b/Lib/test/test_tempfile.py
@@ -937,9 +937,7 @@ def do_create(self, dir=None, pre="", suf="", delete=True):
 
     def test_pathlike(self):
         tmp = self.do_create()
-        self.assertTrue(isinstance(tmp, os.PathLike))
-        cls = type(tmp)
-        self.assertTrue(issubclass(cls, os.PathLike))
+        self.assertIsInstance(tmp, os.PathLike)
 
     def test_basic(self):
         # NamedTemporaryFile can create files
@@ -1592,9 +1590,7 @@ def do_create(self, dir=None, pre="", suf="", recurse=1, dirs=1, files=1,
 
     def test_pathlike(self):
         tmp = self.do_create()
-        self.assertTrue(isinstance(tmp, os.PathLike))
-        cls = type(tmp)
-        self.assertTrue(issubclass(cls, os.PathLike))
+        self.assertIsInstance(tmp, os.PathLike)
 
     def do_create2(self, path, recurse=1, dirs=1, files=1):
         # Create subdirectories and some files