gh-109975: Document crypt_r as a possible replacement of crypt #118439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's worth mentioning you're the author of the |
|
I am not the author (it's dissected from CPython 3.12, authored by others), but I am indeed a maintainer. Other modules in the list do not have their authors/maintainers mentioned. Should I put a disclaimer to the commit message? |
|
No, I just meant for the pull request, as you're kind of advertising the module. |
hugovk
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Duly noted @hroncok is a maintainer, thank you for creating the package and for this PR.
Perhaps drop a note at https://discuss.python.org/t/pep-594-has-been-implemented-python-3-13-removes-20-stdlib-modules/27124 as well?
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--118439.org.readthedocs.build/