[3.7] bpo-35931: Gracefully handle SyntaxError in pdb debug command (GH-11782) #11886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GH-11782) Previously, `debug print(` would cause the interpreter to exit on a SyntaxError whereas `print(` would properly display the error and return to the pdb prompt. This patch fixes this by pre-compiling the code before passing it to `Pdb.run`. https://bugs.python.org/issue35931 (cherry picked from commit 4327705) Co-authored-by: Daniel Hahler <github@thequod.de>
|
@blueyed: Status check is done, and it's a success ✅ . |
1 similar comment
|
@blueyed: Status check is done, and it's a success ✅ . |
zware
approved these changes
Feb 15, 2019
|
This breaks the API (you cannot pass in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
debug print(would cause the interpreter to exit on a SyntaxError whereasprint(would properly display the error and return to the pdb prompt.This patch fixes this by pre-compiling the code before passing it to
Pdb.run.https://bugs.python.org/issue35931
(cherry picked from commit 4327705)
Co-authored-by: Daniel Hahler github@thequod.de
https://bugs.python.org/issue35931