Improve test cases and code

python · lyc8503 · May 11, 2024 · May 23, 2024 · May 23, 2024 · May 23, 2024
commit 42c69ab2ba39043622d60fa0db509e1ba25224b7
diff --git a/Doc/library/http.server.rst b/Doc/library/http.server.rst
@@ -206,7 +206,7 @@ provides three different variants:
 
       .. versionadded:: 3.2
 
-   .. method:: send_error(code, message=None, explain=None, *, extra_headers=None)
+   .. method:: send_error(code, message=None, explain=None, *, extra_headers=())
 
       Sends and logs a complete error reply to the client. The numeric *code*
       specifies the HTTP error code, with *message* as an optional, short, human

diff --git a/Lib/http/server.py b/Lib/http/server.py
@@ -445,7 +445,7 @@ def handle(self):
         while not self.close_connection:
             self.handle_one_request()
 
-    def send_error(self, code, message=None, explain=None, *, extra_headers=None):
+    def send_error(self, code, message=None, explain=None, *, extra_headers=()):
         """Send and log an error reply.
 
         Arguments are
@@ -494,9 +494,8 @@ def send_error(self, code, message=None, explain=None, *, extra_headers=None):
             body = content.encode('UTF-8', 'replace')
             self.send_header("Content-Type", self.error_content_type)
             self.send_header('Content-Length', str(len(body)))
-        if extra_headers is not None:
-            for name, value in extra_headers:
-                self.send_header(name, value)
+        for name, value in extra_headers:
+            self.send_header(name, value)
         self.end_headers()
 
         if self.command != 'HEAD' and body:

diff --git a/Lib/test/test_httpservers.py b/Lib/test/test_httpservers.py
@@ -586,6 +586,12 @@ def test_range_get(self):
         response = self.request(route, headers={'Range': 'bytes=-'})
         self.check_status_and_reason(response, HTTPStatus.OK, data=self.data)
 
+        response = self.request(route, headers={'Range': 'bytes=--'})
+        self.check_status_and_reason(response, HTTPStatus.OK, data=self.data)
+
+        response = self.request(route, headers={'Range': 'bytes='})
+        self.check_status_and_reason(response, HTTPStatus.OK, data=self.data)
+
         # multipart ranges (not supported currently)
         response = self.request(route, headers={'Range': 'bytes=1-2, 4-7'})
         self.check_status_and_reason(response, HTTPStatus.OK, data=self.data)