Skip to content

gh-122450: Fix docs to state denominator positivity of Fraction #122464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Prev Previous commit
Next Next commit
Add docstrings to numerator and denominator of Rational
  • Loading branch information
privet-kitty committed Aug 1, 2024
commit c575b470edb8ccf0928f5ec9fcf236c9ea435bb3
2 changes: 2 additions & 0 deletions Lib/numbers.py
Original file line number Diff line number Diff line change
Expand Up @@ -297,11 +297,13 @@ class Rational(Real):
@property
@abstractmethod
def numerator(self):
"""The numerator of a rational number in lowest terms."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""The numerator of a rational number in lowest terms."""
"""The numerator of a rational number, expressed in its lowest terms."""

raise NotImplementedError

@property
@abstractmethod
def denominator(self):
"""The (positive) denominator of a rational number in lowest terms."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""The (positive) denominator of a rational number in lowest terms."""
"""The (positive) denominator of a rational number, expressed in its lowest terms."""

raise NotImplementedError

# Concrete implementation of Real's conversion to float.
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy