Skip to content

gh-117657: fix race:sock_recv_impl suppressions for free-thread building #123697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 6, 2024
Merged

gh-117657: fix race:sock_recv_impl suppressions for free-thread building #123697

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58ff9b3
gh-123695: fix race:sock_recv_impl suppressions for free-thread building
Zheaoli Sep 4, 2024
81361a0
fix test failed
Zheaoli Sep 4, 2024
756c584
fix review idea
Zheaoli Sep 6, 2024
c5b114b
fix review idea
Zheaoli Sep 6, 2024
4bfd9d9
fix review idea here
Zheaoli Sep 6, 2024
33ac4a3
fix timeout setting
Zheaoli Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix review idea 
Signed-off-by: Manjusaka <me@manjusaka.me>
  • Loading branch information
@Zheaoli
Zheaoli committed Sep 6, 2024
commit c5b114b35357acdd4490851fcff9f93c6f8e7d71
3 changes: 1 addition & 2 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4823,8 +4823,7 @@ def testClose(self):
def _testClose(self):
self.cli.connect((HOST, self.port))
self.cli.send(b'x')
time.sleep(1.0)
read, write, _ = select.select([self.cli], [], [], 0.1)
read, write, _ = select.select([self.cli], [], [], 1.0)
self.assertEqual(read, [self.cli])
self.assertEqual(self.cli.recv(1), b'')

Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy