Skip to content

gh-125470: Fix warning in Python/generated_cases.c.h #125471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2024
Merged

gh-125470: Fix warning in Python/generated_cases.c.h #125471

merged 2 commits into from
Oct 14, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 14, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested a review from markshannon as a code owner October 14, 2024 16:53
@bedevere-app bedevere-app bot mentioned this pull request Oct 14, 2024
Closed
Fidget-Spinner
Fidget-Spinner reviewed Oct 14, 2024
View reviewed changes
@sobolevn
Copy link
Member Author

Failures do not look related:

======================================================================
FAIL: test_timerfd_poll (test.test_os.TimerfdTests.test_timerfd_poll)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_os.py", line 4391, in test_timerfd_poll
    self.check_timerfd_poll(False)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
  File "/home/runner/work/cpython/cpython/Lib/test/test_os.py", line 4387, in check_timerfd_poll
    self.assertGreater(dt, total_time / sec_to_nsec - self.CLOCK_RES)
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0.49887036200016155 not greater than 0.499

----------------------------------------------------------------------

I will merge this, thanks everyone!

@sobolevn sobolevn merged commit 0c8c665 into python:main Oct 14, 2024
52 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @Fidget-Spinner @Eclips4
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy