Skip to content

gh-126028: Add more tests for msvcrt module #126029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

gh-126028: Add more tests for msvcrt module #126029

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
71d7cc7
Add more tests for msvcrt module
aisk Oct 27, 2024
e14193d
Fix typos
aisk Oct 27, 2024
f76b823
Fix another two typos
aisk Oct 27, 2024
b0f2acc
Improve test
aisk Oct 28, 2024
a3f1546
Improve other tests
aisk Oct 28, 2024
13d4345
Check the result in some tests
aisk Oct 28, 2024
fee526e
Merge branch 'main' into msvcrt-more-tests
serhiy-storchaka Jul 13, 2025
c11647c
Update test_GetErrorCode
aisk Jul 16, 2025
54ae00e
Improve test_set_error_mode
aisk Jul 16, 2025
90b904a
Update test CrtSetReportXxx
aisk Jul 16, 2025
79b1e6e
Check if the old is equal to returned in some cases
aisk Jul 17, 2025
d70b3ce
Remove some redundant type check
aisk Jul 17, 2025
c5c4005
Test with extrem values
aisk Jul 17, 2025
62a8389
Fix test
aisk Jul 17, 2025
2d794f3
Fix test_GetErrorMode
aisk Jul 17, 2025
2fbd2e8
Fix test_SetErrorMode
aisk Jul 17, 2025
c3726e1
Fix test_SetErrorMode
aisk Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check if the old is equal to returned in some cases
  • Loading branch information
@aisk
aisk committed Jul 17, 2025
commit 79b1e6ed52d21bf37e3aaf25579f76e1fbd54bb8
3 changes: 3 additions & 0 deletions Lib/test/test_msvcrt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def test_set_error_mode(self):
returned = msvcrt.set_error_mode(msvcrt.OUT_TO_STDERR)
self.assertIs(type(returned), int)
self.assertNotEqual(returned, -1)
self.assertEqual(old, returned)

returned = msvcrt.set_error_mode(msvcrt.REPORT_ERRMODE)
self.assertIs(type(returned), int)
Expand All @@ -151,6 +152,7 @@ def test_CrtSetReportMode(self):
msvcrt.CRTDBG_MODE_DEBUG)
self.assertIs(type(returned), int)
self.assertNotEqual(returned, -1)
self.assertEqual(old, returned)

returned = msvcrt.CrtSetReportMode(msvcrt.CRT_WARN,
msvcrt.CRTDBG_REPORT_MODE)
Expand All @@ -170,6 +172,7 @@ def test_CrtSetReportFile(self):
returned = msvcrt.CrtSetReportFile(msvcrt.CRT_WARN,
msvcrt.CRTDBG_FILE_STDOUT)
self.assertIs(type(returned), int)
self.assertEqual(old_file, returned)

returned = msvcrt.CrtSetReportFile(msvcrt.CRT_WARN,
msvcrt.CRTDBG_REPORT_FILE)
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy