gh-131725: Generate GNU hash table in msgfmt.py
#131727
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@serhiy-storchaka any thoughts? Anything else you would like to see? |
# Conflicts: # Lib/test/test_tools/msgfmt_data/general.mo # Lib/test/test_tools/test_msgfmt.py
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
StanFromIreland
commented
Mar 30, 2025
|
cc @terryjreedy unrelated odd test_idle fails |
tomasr8
reviewed
Mar 30, 2025
StanFromIreland
commented
Mar 30, 2025
|
!buildbot s390x |
|
You don't have write permissions to trigger a build |
|
Can a core dev please call them, we should test the tests on a big endian system. |
StanFromIreland
commented
Mar 30, 2025
Comment on lines
+59
to
+63
| header = struct.unpack("=7I", mo_data[:28]) | ||
| hash_table_size, hash_table_offset = header[5:7] | ||
|
|
||
| hash_tab = struct.unpack(f"={hash_table_size}I", | ||
| mo_data[hash_table_offset : hash_table_offset + (hash_table_size * 4)]) |
There was a problem hiding this comment.
I could just hardcode these sizes since we test them below. Is that preferred?
|
Test_idle failure did not repeat. Next time, copy specific OS and specific failure if you can find it, into your message. |
# Conflicts: # Lib/test/test_tools/msgfmt_data/general.mo
|
@serhiy-storchaka friendly ping:-) |
|
Little ping @tomasr8 / @serhiy-storchaka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.