Skip to content

gh-118761: Improve import time of sqlite3 #131796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve the import time of sqlite3 by 1.5x faster.
  • Loading branch information
Wulian233 committed Jun 6, 2025
commit d3cf658dba37aafbeb5c1a7545186eb886a3abd8
16 changes: 10 additions & 6 deletions Lib/sqlite3/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
import sqlite3
import sys

from argparse import ArgumentParser
from code import InteractiveConsole
from textwrap import dedent


def execute(c, sql, suppress_errors=True):
"""Helper that wraps execution of SQL code.
Expand All @@ -34,13 +30,15 @@ def execute(c, sql, suppress_errors=True):
sys.exit(1)


class SqliteInteractiveConsole(InteractiveConsole):
class SqliteInteractiveConsole:
"""A simple SQLite REPL."""

def __init__(self, connection):
super().__init__()
from code import InteractiveConsole
self._con = connection
self._cur = connection.cursor()
self._console = InteractiveConsole()
self._console.runsource = self.runsource

def runsource(self, source, filename="<input>", symbol="single"):
"""Override runsource, the core of the InteractiveConsole REPL.
Expand All @@ -61,8 +59,14 @@ def runsource(self, source, filename="<input>", symbol="single"):
execute(self._cur, source)
return False

def interact(self, banner, exitmsg=""):
self._console.interact(banner, exitmsg=exitmsg)


def main(*args):
from argparse import ArgumentParser
from textwrap import dedent

Comment on lines 80 to +83
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a valid reason to do code churn and delay imports for the sake of speeding up import sqlite3.__main__ while assuming that sqlite3.__main__.main() is never called.

parser = ArgumentParser(
description="Python sqlite3 CLI",
)
Expand Down
6 changes: 4 additions & 2 deletions Lib/sqlite3/dbapi2.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@
# misrepresented as being the original software.
# 3. This notice may not be removed or altered from any source distribution.

import time
import collections.abc
import datetime
import collections.abc

from _sqlite3 import *

Expand Down Expand Up @@ -54,7 +53,10 @@ def TimestampFromTicks(ticks):
Binary = memoryview
collections.abc.Sequence.register(Row)

# Lazy registe
def register_adapters_and_converters():
global _lazy_register
_lazy_register = lambda: None # Prevent multiple registration # noqa: E731
from warnings import warn

msg = ("The default {what} is deprecated as of Python 3.12; "
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Halve the import time of :mod:`sqlite3`.
Improve the import time of :mod:`sqlite3` by 1.5x faster.
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy