-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
gh-118761: Improve import time of sqlite3
#131796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Wulian233
wants to merge
6
commits into
python:main
Choose a base branch
from
Wulian233:sqlite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4b04bdf
ok
Wulian233 d3cf658
Improve the import time of `sqlite3` by 1.5x faster.
Wulian233 4373d47
Merge branch 'main' into sqlite
Wulian233 def1974
fix & finish
Wulian233 04eedab
Update dbapi2.py
Wulian233 ccf3575
fix
Wulian233 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Improve the import time of
sqlite3
by 1.5x faster.
- Loading branch information
commit d3cf658dba37aafbeb5c1a7545186eb886a3abd8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,10 +7,6 @@ | |
import sqlite3 | ||
import sys | ||
|
||
from argparse import ArgumentParser | ||
from code import InteractiveConsole | ||
from textwrap import dedent | ||
|
||
|
||
def execute(c, sql, suppress_errors=True): | ||
"""Helper that wraps execution of SQL code. | ||
|
@@ -34,13 +30,15 @@ def execute(c, sql, suppress_errors=True): | |
sys.exit(1) | ||
|
||
|
||
class SqliteInteractiveConsole(InteractiveConsole): | ||
class SqliteInteractiveConsole: | ||
"""A simple SQLite REPL.""" | ||
|
||
def __init__(self, connection): | ||
super().__init__() | ||
from code import InteractiveConsole | ||
self._con = connection | ||
self._cur = connection.cursor() | ||
self._console = InteractiveConsole() | ||
self._console.runsource = self.runsource | ||
|
||
def runsource(self, source, filename="<input>", symbol="single"): | ||
"""Override runsource, the core of the InteractiveConsole REPL. | ||
|
@@ -61,8 +59,14 @@ def runsource(self, source, filename="<input>", symbol="single"): | |
execute(self._cur, source) | ||
return False | ||
|
||
def interact(self, banner, exitmsg=""): | ||
self._console.interact(banner, exitmsg=exitmsg) | ||
|
||
|
||
def main(*args): | ||
from argparse import ArgumentParser | ||
from textwrap import dedent | ||
|
||
Comment on lines
80
to
+83
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do not see a valid reason to do code churn and delay imports for the sake of speeding up |
||
parser = ArgumentParser( | ||
description="Python sqlite3 CLI", | ||
) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
Misc/NEWS.d/next/Library/2025-01-21-14-51-44.gh-issue-118761.Z0F-d5.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
Halve the import time of :mod:`sqlite3`. | ||
Improve the import time of :mod:`sqlite3` by 1.5x faster. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.