Skip to content

gh-118761: Optimise import time for string #132037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 8, 2025
Merged

gh-118761: Optimise import time for string #132037

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ec78492
Optimise import time for ``string``
AA-Turner Apr 3, 2025
2b542c7
Refactor to a common classmethod
AA-Turner Apr 3, 2025
e28e43f
Add comment
AA-Turner Apr 3, 2025
056dd07
Use None as the sentinel
AA-Turner Apr 6, 2025
bb3605a
Make _TemplatePattern a singleton
AA-Turner Apr 7, 2025
6fb9b5d
Serhiy's suggestion
AA-Turner Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use None as the sentinel
  • Loading branch information
@AA-Turner
AA-Turner committed Apr 6, 2025
commit 056dd07bb50834ee07601661ff00de6f6bcd72fd
5 changes: 2 additions & 3 deletions Lib/string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def capwords(s, sep=None):

####################################################################
_sentinel_dict = {}
_sentinel_flags = object()


class _TemplatePattern:
Expand All @@ -71,7 +70,7 @@ class Template:
# See https://bugs.python.org/issue31672
idpattern = r'(?a:[_a-z][_a-z0-9]*)'
braceidpattern = None
flags = _sentinel_flags # default: re.IGNORECASE
flags = None # default: re.IGNORECASE

pattern = _TemplatePattern() # use a descriptor to compile the pattern

Expand Down Expand Up @@ -99,7 +98,7 @@ def _compile_pattern(cls):
(?P<invalid>) # Other ill-formed delimiter exprs
)
"""
if cls.flags is _sentinel_flags:
if cls.flags is None:
cls.flags = re.IGNORECASE
pat = cls.pattern = re.compile(pattern, cls.flags | re.VERBOSE)
return pat
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy