Skip to content

gh-133346: Make theming support in _colorize extensible #133347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 5, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make no_colors() into classmethods
  • Loading branch information
ambv committed May 5, 2025
commit 5c45ddbb40b7afc906bb08cb960a9d3f39edd6bb
20 changes: 11 additions & 9 deletions Lib/_colorize.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,12 @@ def copy_with(self, **kwargs: str) -> Self:
color_state.update(kwargs)
return type(self)(**color_state)

def no_colors(self) -> Self:
@classmethod
def no_colors(cls) -> Self:
color_state: dict[str, str] = {}
for color_name in self.__dataclass_fields__:
for color_name in cls.__dataclass_fields__:
color_state[color_name] = ""
return type(self)(**color_state)
return cls(**color_state)

def __getitem__(self, key: str) -> str:
return self._name_to_value(key)
Expand Down Expand Up @@ -219,18 +220,19 @@ def copy_with(
unittest=unittest or self.unittest,
)

def no_colors(self) -> Self:
@classmethod
def no_colors(cls) -> Self:
"""Return a new Theme where colors in all sections are empty strings.

This allows writing user code as if colors are always used. The color
fields will be ANSI color code strings when colorization is desired
and possible, and empty strings otherwise.
"""
return type(self)(
argparse=self.argparse.no_colors(),
syntax=self.syntax.no_colors(),
traceback=self.traceback.no_colors(),
unittest=self.unittest.no_colors(),
return cls(
argparse=Argparse.no_colors(),
syntax=Syntax.no_colors(),
traceback=Traceback.no_colors(),
unittest=Unittest.no_colors(),
)


Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy