Skip to content

gh-133999: Fix except parsing regression in 3.14 #134035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2025
Merged

gh-133999: Fix except parsing regression in 3.14 #134035

merged 1 commit into from
May 17, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 15, 2025 •
edited by bedevere-app bot
Loading

Basically, we only need to parse as a=expression second-pass case, when block can be parsed further. Otherwise, it is a problem with block, not except

@bedevere-app bedevere-app bot mentioned this pull request May 15, 2025
Closed
@sobolevn sobolevn merged commit 84914ad into python:main May 17, 2025
45 checks passed
@sobolevn
Copy link
Member Author

Thanks, @pablogsal

@encukou encukou added the needs backport to 3.14 bugs and security fixes label May 19, 2025
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2025
@sobolevn @miss-islington
pythongh-133999: Fix except parsing regression in 3.14 (pythonGH-13…
0ccff19 
…4035)

(cherry picked from commit 84914ad)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented May 19, 2025

GH-134206 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 19, 2025
sobolevn added a commit that referenced this pull request May 19, 2025
@miss-islington @sobolevn
[3.14] gh-133999: Fix except parsing regression in 3.14 (GH-134035) (…
d9c08c5 
…#134206)

gh-133999: Fix `except` parsing regression in 3.14 (GH-134035)
(cherry picked from commit 84914ad)

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @pablogsal @encukou
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy