gh-134170: Add colorization to unraisable exceptions #134183

ZeroIntensity · 2025-05-18T15:03:16Z

It's pretty now:

I don't think it's worth it/possible to add a test for this.

Issue: Add colorization of exceptions in default sys.unraisablehook #134170

📚 Documentation preview 📚: https://cpython-previews--134183.org.readthedocs.build/

Doc/whatsnew/3.15.rst

Lib/test/test_signal.py

Python/errors.c

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

picnixz

Let's this by raising an unraisable exception inside the hook itself and check that we don't crash. I don't know if we can recursively call sys.unraisablehook because of that, but if we can, we should check that we don't segfault for whatever reason.

Python/errors.c

…e reason.

ZeroIntensity · 2025-06-02T09:50:44Z

Sorry, forgot about this PR!

Let's this by raising an unraisable exception inside the hook itself and check that we don't crash. I don't know if we can recursively call sys.unraisablehook because of that, but if we can, we should check that we don't segfault for whatever reason.

I think this makes sense for a follow-up, because it'll apply to the current implementation as well, right? Ideally, that test would get backported.

In general, we shouldn't have to worry too much about breaking things here, because we're just adding execution of Python code to a path where you could already execute arbitrary Python code.

picnixz · 2025-06-02T10:16:23Z

I think this makes sense for a follow-up, because it'll apply to the current implementation as well, right? Ideally, that test would get backported.

Yes.

Doc/whatsnew/3.15.rst

Lib/test/test_capi/test_exceptions.py

Misc/NEWS.d/next/Core_and_Builtins/2025-05-18-10-50-46.gh-issue-134170.J0Hvmi.rst

Python/errors.c

picnixz · 2025-08-03T18:14:55Z

Python/errors.c

+        Py_XDECREF(result);
+        if (result != NULL) {


Let's avoid checking dangling pointers. Let's do int ok = result != NULL; Py_XDECREF(result); and compare ok afterwards.

Python/errors.c

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

…python into unraisable-color

picnixz

Sorry last nitpicks.

Doc/library/sys.rst

Python/errors.c

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Lib/traceback.py

Python/errors.c

Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner

LGTM

Python/errors.c

…ble-color

ZeroIntensity added 5 commits May 18, 2025 10:49

Add colorization to unraisable exceptions.

e8ea2a3

Add blurb.

36e38e6

Add whatsnew.

6c9d619

Clear exceptions upon failure.

d2e621a

Remove stray newline change.

411406c

ZeroIntensity requested review from hugovk and picnixz May 18, 2025 15:03

bedevere-app bot mentioned this pull request May 18, 2025

Add colorization of exceptions in default sys.unraisablehook #134170

Closed

bedevere-app bot added the awaiting review label May 18, 2025

ZeroIntensity added 7 commits May 18, 2025 11:13

Fix signal tests.

4e9a0b6

Fix cmdline tests.

19db581

Fix sys tests.

6e57c96

Oops I lied.

06d43dd

Fix atexit tests.

ca0efb4

Skip unneeded @force_not_colorized

bcfd811

Fix C API tests.

b329019

picnixz reviewed May 18, 2025

View reviewed changes

Doc/whatsnew/3.15.rst Show resolved Hide resolved

Lib/test/test_signal.py Outdated Show resolved Hide resolved

Python/errors.c Show resolved Hide resolved

Python/errors.c Show resolved Hide resolved

ZeroIntensity and others added 5 commits May 18, 2025 11:34

Fix remaining tests.

8a325d3

Fix remaining tests.

2360427

Apply suggestions from code review

9a1d88e

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Pass the file instead of looking up sys.stderr again.

a8cf99a

Change stupid test case.

b32084c

picnixz reviewed May 18, 2025

View reviewed changes

Python/errors.c Show resolved Hide resolved

Python/errors.c Show resolved Hide resolved

ZeroIntensity added 2 commits May 18, 2025 12:28

Please let this fix the stupid test. It doesn't repro locally for som…

79fb9d2

…e reason.

Add a comment to make Benedikt happy.

4c339f3

Fix the comment about the file parameter.

2793964

Merge branch 'main' into unraisable-color

e96740b

ZeroIntensity requested a review from picnixz August 3, 2025 18:03

Fix potential double-decref.

63892dc

picnixz reviewed Aug 3, 2025

View reviewed changes

ZeroIntensity and others added 5 commits August 3, 2025 14:20

Apply suggestions from code review

0547bf0

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Avoid checking dangling pointer against NULL.

0822b6c

Make NEWS entry clearer.

7f36267

Update the documentation for sys.unraisablehook().

91e1048

Merge branch 'unraisable-color' of https://github.com/zerointensity/c…

ee2edd5

…python into unraisable-color

picnixz reviewed Aug 3, 2025

View reviewed changes

Doc/library/sys.rst Outdated Show resolved Hide resolved

Python/errors.c Outdated Show resolved Hide resolved

Python/errors.c Outdated Show resolved Hide resolved

Apply suggestions from code review

7deb130

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

vstinner reviewed Aug 4, 2025

View reviewed changes

Lib/traceback.py Outdated Show resolved Hide resolved

Python/errors.c Outdated Show resolved Hide resolved

ZeroIntensity and others added 2 commits August 4, 2025 09:05

Update Python/errors.c

f2c8dd7

Co-authored-by: Victor Stinner <vstinner@python.org>

Update Lib/traceback.py

4c3a6e7

Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner approved these changes Aug 4, 2025

View reviewed changes

Python/errors.c Show resolved Hide resolved

bedevere-app bot added awaiting merge and removed awaiting review labels Aug 4, 2025

ZeroIntensity added 2 commits August 4, 2025 10:08

Newline for readability.

53fb7a8

Merge branch 'main' of https://github.com/python/cpython into unraisa…

37d87a0

…ble-color

ZeroIntensity enabled auto-merge (squash) August 4, 2025 14:10

picnixz approved these changes Aug 4, 2025

View reviewed changes

ZeroIntensity merged commit e8251dc into python:main Aug 4, 2025
41 checks passed

bedevere-app bot removed the awaiting merge label Aug 4, 2025

ZeroIntensity deleted the unraisable-color branch August 4, 2025 14:41

Uh oh!

gh-134170: Add colorization to unraisable exceptions #134183

gh-134170: Add colorization to unraisable exceptions #134183

Conversation

ZeroIntensity commented May 18, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ZeroIntensity commented Jun 2, 2025

Uh oh!

picnixz commented Jun 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

ZeroIntensity Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

ZeroIntensity commented May 18, 2025 •

edited by github-actions bot

Loading