Skip to content

gh-133579: consistently report C curses function failures #134327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 27, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented May 20, 2025

@picnixz
Copy link
Member Author

picnixz commented May 23, 2025

I've removed useless comments because I think it'll only confuse readers.

@picnixz picnixz requested a review from vstinner May 23, 2025 12:31
picnixz and others added 2 commits May 24, 2025 23:44
Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a NEWS entry. You should document that some functions can now fail and that the exception type changed in some existing error handling code paths.

@picnixz picnixz enabled auto-merge (squash) May 27, 2025 09:55
@picnixz picnixz disabled auto-merge May 27, 2025 09:55
@picnixz picnixz enabled auto-merge (squash) May 27, 2025 09:57
@picnixz picnixz merged commit 30dde1e into python:main May 27, 2025
39 checks passed
@picnixz picnixz deleted the fix/curses/more-error-reports-133579 branch May 30, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy