Skip to content

gh-134449: fix grammar for precision_with_grouping in format description #134608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

gh-134449: fix grammar for precision_with_grouping in format description #134608

merged 1 commit into from
Jun 2, 2025

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented May 24, 2025 •
edited by github-actions bot
Loading

@skirpichev
pythongh-134449: fix grammar for precision_with_grouping in format de…
ada07e7 
…scription

This amends f39a07b.  Thanks to Jonathan Poelen.
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels May 24, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 24, 2025
Open
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 24, 2025
@skirpichev skirpichev added the needs backport to 3.14 bugs and security fixes label May 24, 2025
@skirpichev skirpichev requested a review from picnixz May 25, 2025 09:43
@picnixz picnixz merged commit 7828d52 into python:main Jun 2, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jun 2, 2025
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2025
@skirpichev @miss-islington
pythongh-134449: fix grammar for precision_with_grouping in format …
43b14dd 
…description (pythonGH-134608)

This amends commit f39a07b.
(cherry picked from commit 7828d52)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 2, 2025

GH-135015 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 2, 2025
@picnixz picnixz changed the title gh-134449: fix grammar for precision_with_grouping in format description gh-134449: fix grammar for precision_with_grouping in format description Jun 2, 2025
picnixz pushed a commit that referenced this pull request Jun 2, 2025
@miss-islington @skirpichev
[3.14] gh-134449: fix grammar for precision_with_grouping in format…
16d5bdd 
… description (GH-134608) (#135015)

gh-134449: fix grammar for `precision_with_grouping` in format description (GH-134608)

This amends commit f39a07b.
(cherry picked from commit 7828d52)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@skirpichev skirpichev deleted the fix-precision_with_grouping-descr/134449 branch June 2, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skirpichev @picnixz
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy