Skip to content

gh-109934: notify cancelled futures on thread pool shutdown #134618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

gh-109934: notify cancelled futures on thread pool shutdown #134618

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8040f9a
gh-109934: notify cancelled futures on thread pool shutdown
duaneg May 24, 2025
bb89020
Add reference to GH issue
duaneg Jul 15, 2025
ff70843
gh-136655: ensure cancelled futures are notified on process pool shut…
duaneg Jul 15, 2025
df11bf3
Ignore broken barrier errors when waiting on the barrier in the main …
duaneg Jul 15, 2025
ffdcb27
Catch BrokenBarrierError in another place it can be thrown and mentio…
duaneg Jul 15, 2025
8e2b573
Fix another race condition in the threading executor test: ensure the…
duaneg Jul 15, 2025
bc3751e
Attempt to make the unit test more robust and clean up process manage…
duaneg Jul 16, 2025
ff0d951
Merge branch 'main' into gh-109934
duaneg Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add reference to GH issue
  • Loading branch information
@duaneg
duaneg committed Jul 15, 2025
commit bb89020fef4f77663add656b9b8b9df3a8df45ac
1 change: 1 addition & 0 deletions Lib/test/test_concurrent_futures/test_thread_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ def log_n_wait(ident):
self.assertListEqual(log, ["ident='first' started", "ident='first' stopped"])

def test_shutdown_cancels_pending_futures(self):
# gh-109934: ensure shutdown cancels and notifies pending futures
def waiter(barrier):
barrier.wait(3)
def noop():
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy