Skip to content

gh-133579: correctly report C curses errors in _curses_panel #134629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 8, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented May 24, 2025

This was part of #125844 but I extracted it from there because it wasn't necessary. I'll make it part of gh-133579 instead of gh-125843 because the other one was more for curses module itself and this one is a follow-up (and also because I changed some exception types)

@picnixz picnixz requested a review from encukou May 24, 2025 12:26
@picnixz picnixz changed the title gh-125843: correctly report C curses errors in _curses_panel gh-133579: correctly report C curses errors in _curses_panel May 24, 2025
@picnixz picnixz requested a review from vstinner May 30, 2025 13:57
@encukou
Copy link
Member

encukou commented Jun 6, 2025

Looks good! Sorry for the delay.
Let's merge if the buildbots don't complain.

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 6, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit e6c00d0 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134629%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 6, 2025
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buildbot failures are unrelated.
I don't mind keeping the comment in. Do you really want to remove it?

@picnixz
Copy link
Member Author

picnixz commented Jun 7, 2025

Do you really want to remove it?

Not really, though I think I can remove it if we go through all modules that don't correctly assert this (but in a follow-up). In practice, I don't think it'll be an issue as such functions are internal-only, so issues would be caught at review time. We could do more expensive checks on DEBUG builds though.

I think I wanted to remove it because I expected that this issue was already well-known and that my comment could have been "too much".

@picnixz picnixz self-assigned this Jun 7, 2025
@encukou
Copy link
Member

encukou commented Jun 7, 2025

So let's merge this as is?
(You just assigned yourself, does that mean you want to do something more?)

@picnixz
Copy link
Member Author

picnixz commented Jun 7, 2025

(You just assigned yourself, does that mean you want to do something more?)

I assign the PR to myself when I want to merge it later, otherwise I forget about the PR. But if you want to merge it before, you can go ahead!

@picnixz
Copy link
Member Author

picnixz commented Jun 7, 2025

Also, I myself only merge stuff when I'm on Linux as I can revert or make a fast patch if something breaks just after (I'm currently on Windows since I'm playing). So usually I merge my PRs when I'm back on Linux.

@picnixz picnixz merged commit d610f11 into python:main Jun 8, 2025
117 of 127 checks passed
@picnixz picnixz deleted the fix/curses/panel-better-errors-125843 branch June 8, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy