Skip to content

gh-134151 Fix TypeError in email.utils.decode_params() when sorting RFC 2231 continuations #134687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 8, 2025
Merged

gh-134151 Fix TypeError in email.utils.decode_params() when sorting RFC 2231 continuations #134687

merged 7 commits into from
Jun 8, 2025

Conversation

zangjiucheng
Copy link
Contributor

@zangjiucheng zangjiucheng commented May 26, 2025 •
edited by bedevere-app bot
Loading

@zangjiucheng
Fix TypeError in email.utils.decode_params() when sorting RFC 2231 co…
fa95d8e 
…ntinuations on Python 3 and add corresponding test case
@zangjiucheng zangjiucheng requested a review from a team as a code owner May 26, 2025 04:55
@bedevere-app bedevere-app bot mentioned this pull request May 26, 2025
Open
bitdancer
bitdancer reviewed May 26, 2025
View reviewed changes
@zangjiucheng zangjiucheng requested a review from bitdancer May 27, 2025 18:07
bitdancer
bitdancer requested changes Jun 7, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Jun 7, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@zangjiucheng
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jun 7, 2025

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from bitdancer June 7, 2025 20:45
@bitdancer bitdancer added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 7, 2025
picnixz
picnixz reviewed Jun 7, 2025
View reviewed changes
@picnixz picnixz changed the title gh-134151 Fix TypeError in email.utils.decode_params() when sorting RFC 2231 continuations on Python 3 gh-134151 Fix TypeError in email.utils.decode_params() when sorting RFC 2231 continuations Jun 7, 2025
picnixz
picnixz reviewed Jun 7, 2025
View reviewed changes
@picnixz
Copy link
Member

picnixz commented Jun 7, 2025 •
edited
Loading

I'll merge this tomorrow if it's not already merged; I'm a bit too tired for writing a commit message now :')

@zangjiucheng
Copy link
Contributor Author

Thanks for your guys’ reviews! @picnixz, take care and enjoy your night :D

I'll merge this tomorrow if it's not already merged; I'm a bit too tired for writing a commit message now :')

@picnixz picnixz merged commit bcb6b45 into python:main Jun 8, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks @zangjiucheng for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2025
@zangjiucheng @miss-islington
pythongh-134151 Fix TypeError in email.utils.decode_params when s…
be338b2 
…orting RFC 2231 continuations (pythonGH-134687)

- Fix sorting logic in `email.utils.decode_params` to handle None values.
- Update tests for RFC 2231 continuation sorting.
(cherry picked from commit bcb6b45)

Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 8, 2025

GH-135247 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 8, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2025
@zangjiucheng @miss-islington
pythongh-134151 Fix TypeError in email.utils.decode_params when s…
b346f6d 
…orting RFC 2231 continuations (pythonGH-134687)

- Fix sorting logic in `email.utils.decode_params` to handle None values.
- Update tests for RFC 2231 continuation sorting.
(cherry picked from commit bcb6b45)

Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 8, 2025

GH-135248 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 8, 2025
picnixz pushed a commit that referenced this pull request Jun 8, 2025
@miss-islington @zangjiucheng
[3.13] gh-134151 Fix TypeError in email.utils.decode_params when …
e5d1771 
…sorting RFC 2231 continuations (GH-134687) (#135248)

gh-134151 Fix `TypeError` in `email.utils.decode_params` when sorting RFC 2231 continuations (GH-134687)

- Fix sorting logic in `email.utils.decode_params` to handle None values.
- Update tests for RFC 2231 continuation sorting.
(cherry picked from commit bcb6b45)

Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
picnixz pushed a commit that referenced this pull request Jun 8, 2025
@miss-islington @zangjiucheng
[3.14] gh-134151 Fix TypeError in email.utils.decode_params when …
85efa77 
…sorting RFC 2231 continuations (GH-134687) (#135247)

gh-134151 Fix `TypeError` in `email.utils.decode_params` when sorting RFC 2231 continuations (GH-134687)

- Fix sorting logic in `email.utils.decode_params` to handle None values.
- Update tests for RFC 2231 continuation sorting.
(cherry picked from commit bcb6b45)

Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@bitdancer bitdancer bitdancer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zangjiucheng @picnixz @bitdancer
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy