Skip to content

gh-134986: Catch PermissionError when trying to call perf in tests #134987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-134986: Catch PermissionError when trying to call perf in tests #134987

wants to merge 2 commits into from

Conversation

emmatyping
Copy link
Member

@emmatyping emmatyping commented May 31, 2025 •
edited
Loading

Using Ubuntu 24.04 on the Windows Subsystem for Linux, perf will raise a PermissionError instead of FileNotFoundError when it is missing. This PR modifies the tests to catch that.

@emmatyping
Catch PermissionError when trying to call perf in tests
52a365f 
Using Ubuntu 24.04 on the Windows Subsystem for Linux, perf will raise a
`PermissionError` instead of `FileNotFoundError`. This commit modifies
the tests to catch that.
@emmatyping emmatyping added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 31, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 31, 2025
Open
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label May 31, 2025
terryjreedy
terryjreedy reviewed May 31, 2025
View reviewed changes
@emmatyping emmatyping requested a review from terryjreedy June 4, 2025 01:53
vstinner
vstinner approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees
No one assigned
Labels
awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmatyping @vstinner @terryjreedy
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy