gh-134875: Fix mimallc build error for the old compilers #134994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
commented
Jun 1, 2025
| @@ -634,10 +634,10 @@ static inline mi_block_t* mi_block_nextx( const void* null, const mi_block_t* bl | |||
| mi_track_mem_defined(block,sizeof(mi_block_t)); | |||
| mi_block_t* next; | |||
| #ifdef MI_ENCODE_FREELIST | |||
| next = (mi_block_t*)mi_ptr_decode(null, mi_atomic_load_relaxed(&block->next), keys); | |||
| next = (mi_block_t*)mi_ptr_decode(null, mi_atomic_load_relaxed((_Atomic(mi_encoded_t)*)&block->next), keys); | |||
There was a problem hiding this comment.
block is declared as const mi_block_t* block, so this issue happens. other way is to change the function signature, but I don't prefer it.
|
@corona10 Thank you, I can confirm that this fixes the compilation error. |
|
Let's wait @colesbury before merging this PR. Thanks for the verification. |
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 2, 2025
…ngh-134994) (cherry picked from commit b525e31) Co-authored-by: Donghee Na <donghee.na@python.org>
|
GH-135053 is a backport of this pull request to the 3.14 branch. |
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 2, 2025
…ngh-134994) (cherry picked from commit b525e31) Co-authored-by: Donghee Na <donghee.na@python.org>
|
GH-135054 is a backport of this pull request to the 3.13 branch. |
corona10
added a commit
that referenced
this pull request
Jun 3, 2025
corona10
added a commit
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.