Skip to content

Fix zipfile._Extra.split #134999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

danny0838
Copy link

As a class method, it should call from cls instead of _Extra.

@bedevere-app
Copy link

bedevere-app bot commented Jun 1, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make an issue.

@danny0838
Copy link
Author

The instruction says:

Trivial changes, like fixing a typo, do not need an issue.

I think this fix is obvious and trivial enough that an extra issue is overkill.

@ZeroIntensity
Copy link
Member

We need issues for actual bugs. They aren't needed for things like documentation changes.

@danny0838
Copy link
Author

danny0838 commented Jun 3, 2025

I don't know what should be put in the issue body.

The original code is a bad design and may cause an issue if someone extends the _Extra class, but it does not cause an actual bug so far as _Extra is only used internally.

@ZeroIntensity
Copy link
Member

The original code is a bad design and may cause an issue if someone extends the _Extra class, but it does not cause an actual bug so far as _Extra is only used internally.

Not disagreeing, but in practice, people will just fix that on the fly. It's typically not worth it to prematurely fix internal APIs.

I'm going to leave this one up to @jaraco who wrote the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy