Skip to content

gh-135001: Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8' #135002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Jun 1, 2025

@Wulian233 Wulian233 changed the title gh-135001: Change the default parameter value of calendar.HTMLCalendar to utf-8 gh-135001: Change the default encoding parameter value of calendar.HTMLCalendar to utf-8 Jun 1, 2025
@picnixz picnixz marked this pull request as draft June 1, 2025 12:07
@picnixz
Copy link
Member

picnixz commented Jun 1, 2025

Making it a draft as it's a WIP.

@Wulian233 Wulian233 marked this pull request as ready for review June 1, 2025 13:00
@Wulian233 Wulian233 requested a review from picnixz June 1, 2025 13:39
picnixz
picnixz previously requested changes Jun 2, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jun 2, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Wulian233
Copy link
Contributor Author

The new commit resolves the above review and requires you to confirm that it is resolved. Thanks!

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jun 2, 2025

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from picnixz June 2, 2025 08:38
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sys.getdefaultencoding() always returns "utf-8", so this PR doesn't change the default encoding. If you want, you can replace sys.getdefaultencoding() with "utf-8". But I don't think that it should be documented.

@Wulian233 Wulian233 changed the title gh-135001: Change the default encoding parameter value of calendar.HTMLCalendar to utf-8 gh-135001: Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8' Jun 6, 2025
@Wulian233
Copy link
Contributor Author

sys.getdefaultencoding() always returns "utf-8", so this PR doesn't change the default encoding. If you want, you can replace sys.getdefaultencoding() with "utf-8". But I don't think that it should be documented.

I just using git reset was not the right thing to do, and I apologize for that. I honestly didn’t consider this at the time

I’ve added a news entry, do you think that’s necessary?

@vstinner
Copy link
Member

vstinner commented Jun 6, 2025

I’ve added a news entry, do you think that’s necessary?

I don't think that it's necessary.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
Copy link
Member

vstinner commented Jun 9, 2025

test_syntax was failing on the CI. I updated the branch to try to repair the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy