-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-135001: Explicitly specify the encoding parameter value of calendar.HTMLCalendar
as 'utf-8'
#135002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
calendar.HTMLCalendar
to utf-8calendar.HTMLCalendar
to utf-8
Making it a draft as it's a WIP. |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
The new commit resolves the above review and requires you to confirm that it is resolved. Thanks! I have made the requested changes; please review again |
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
Misc/NEWS.d/next/Library/2025-06-01-19-45-55.gh-issue-135001.KsBXSl.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sys.getdefaultencoding() always returns "utf-8", so this PR doesn't change the default encoding. If you want, you can replace sys.getdefaultencoding() with "utf-8". But I don't think that it should be documented.
calendar.HTMLCalendar
to utf-8calendar.HTMLCalendar
as 'utf-8'
I just using git reset was not the right thing to do, and I apologize for that. I honestly didn’t consider this at the time I’ve added a news entry, do you think that’s necessary? |
I don't think that it's necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test_syntax was failing on the CI. I updated the branch to try to repair the CI. |
calendar.HTMLCalendar
as 'utf-8' #135001📚 Documentation preview 📚: https://cpython-previews--135002.org.readthedocs.build/