Skip to content

gh-116738: Make _heapq module thread-safe #135036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 9, 2025
Merged

gh-116738: Make _heapq module thread-safe #135036

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ec3cade
gh-116738: Make _heapq module thread-safe
yoney May 27, 2025
01b2be4
gh-116738: Add news entry in Misc/NEWS/next
yoney Jun 2, 2025
68f3a26
gh-116738: Address the review comments
yoney Jun 3, 2025
41d145a
gh-116738: Address the review comments
yoney Jun 3, 2025
a22da8f
gh-116738: Remove type hints
yoney Jun 4, 2025
75a1d3a
gh-116738: Address the review comments
yoney Jun 5, 2025
e8138be
gh-116738: Add NULL check for the item arg in heappush()
yoney Jun 5, 2025
3f09689
gh-116738: Fix typo
yoney Jun 5, 2025
7ffdb6d
gh-116738: Use invariant checks from heapq test
yoney Jun 5, 2025
c2225a5
gh-116738: Remove forgotten type hint
yoney Jun 9, 2025
a196a00
Merge branch 'main' into ft_heapq
mpage Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-116738: Fix typo
  • Loading branch information
@yoney
yoney committed Jun 5, 2025
commit 3f0968925d303caa7dacde714883b65bb486d479
2 changes: 1 addition & 1 deletion Lib/test/test_free_threading/test_heapq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def run_concurrently(self, worker_func, args, nthreads) -> None:
barrier = Barrier(nthreads)

def wrapper_func(*args):
# Wait for all threadss to reach this point before proceeding.
# Wait for all threads to reach this point before proceeding.
barrier.wait()
worker_func(*args)

Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy