Skip to content

gh-116738: Inline append for local PyList #135196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

gh-116738: Inline append for local PyList #135196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Modules/grpmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#include "Python.h"
#include "posixmodule.h"
#include "pycore_list.h" // _PyList_AppendTakeRef()

#include <errno.h> // ERANGE
#include <grp.h> // getgrgid_r()
Expand Down Expand Up @@ -295,8 +296,12 @@ grp_getgrall_impl(PyObject *module)
// setgrent()/endgrent() are not reentrant / thread-safe. A deadlock
// is unlikely since mkgrent() should not be able to call arbitrary
// Python code.
// `d` is a local list; append to it without a lock using
// _PyList_AppendTakeRef().
PyObject *v = mkgrent(module, p);
if (v == NULL || PyList_Append(d, v) != 0) {
if (v == NULL
|| _PyList_AppendTakeRef((PyListObject *)d, Py_NewRef(v)) != 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an assertion for _PyObject_IsUniquelyReferenced or Py_REFCNT() == 1.

{
Py_XDECREF(v);
Py_CLEAR(d);
goto done;
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy