gh-135148: Correctly handle f/t strings with comments and debug expressions #135198
+76
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd49471 to
5f8456e
Compare
pablogsal
commented
Jun 6, 2025
Parser/lexer/lexer.c
Outdated
|
|
||
| // Process each character of input |
There was a problem hiding this comment.
@lysnikolaou please read this carefully. I am mostly sure its correct but it really needs some extra eyes
lysnikolaou
requested changes
Jun 6, 2025
|
When you're done making the requested changes, leave the comment: |
lysnikolaou
reviewed
Jun 9, 2025
There was a problem hiding this comment.
This looks good now! Thanks @pablogsal!
I left a couple of inline comments for some very minor improvements.
Comment on lines
+141
to
+147
| if (!in_string) { | ||
| in_string = 1; | ||
| quote_char = ch; | ||
| } | ||
| else if (ch == quote_char) { | ||
| in_string = 0; | ||
| } |
There was a problem hiding this comment.
This only works because there's always an odd number of quotes in a STRING token and we're sure that all STRING tokens will be valid at this point. Maybe add a comment to explain that?
Comment on lines
+127
to
+128
| char quote_char = 0; | ||
| char string_quote = 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.