Skip to content

gh-135261: add CI job for testing OpenSSL 1.1.1w #135262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-135261: add CI job for testing OpenSSL 1.1.1w #135262

wants to merge 1 commit into from
+1 −1

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jun 8, 2025 •
edited by bedevere-app bot
Loading

I don't think I need to regen the OpenSSL data here so I'll just check if the CI job works.

@bedevere-app bedevere-app bot mentioned this pull request Jun 8, 2025
Open
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 8, 2025
@picnixz
Copy link
Member Author

picnixz commented Jun 8, 2025

Ok, everything looks good. I'll let a code owner merge this one (I don't need it immediately, but it can ease my life later on)

@ned-deily
Copy link
Member

FTR, this PR would effectively revert #123701 from nine months ago. Do we want to do that?

@picnixz
Copy link
Member Author

picnixz commented Jun 8, 2025 •
edited
Loading

I do want it because we have code that is conditioned to OpenSSL version. And the (official) build requirements are still 1.1.1w so it makes sense to test this. Otherwise I don't know when we test those paths.

@AA-Turner
Copy link
Member

cc @zware

@ned-deily
Copy link
Member

ned-deily commented Jun 8, 2025 •
edited
Loading

See my comment on the issue: in short, we should update the build requirements docs and not provide free support for something that the OpenSSL project charges lots of money for.

@gpshead, any opinions on this?

@ned-deily
Copy link
Member

If we do agree to update the build requirements doc, we should also update the OpenSSL version test in configure.ac to issue an unsupported warning if attempting to build with a 1.1.1 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees
No one assigned
Labels
awaiting core review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picnixz @ned-deily @AA-Turner
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy