Skip to content

gh-133390: Support SQL keyword completion for sqlite3 CLI (#133393) #135292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025
Merged

gh-133390: Support SQL keyword completion for sqlite3 CLI (#133393) #135292

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10f822b
gh-133390: Support SQL keyword completion for sqlite3 CLI (#133393)
tanloong Jun 6, 2025
a59ec6a
Pass env variables to test subprocess
encukou Jun 9, 2025
bd6a870
Import unittest.mock, so test_sqlite3.test_cli works on its own
encukou Jun 9, 2025
3d9721a
Dump output on error in verbose mode
encukou Jun 10, 2025
f1fa6c7
Disable readline's show-all settings
encukou Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Import unittest.mock, so test_sqlite3.test_cli works on its own
  • Loading branch information
@encukou
encukou committed Jun 9, 2025
commit bd6a870d8225b19727922f3d11abb022160bad58
1 change: 1 addition & 0 deletions Lib/test/test_sqlite3/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import sys
import textwrap
import unittest
import unittest.mock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used on line 203.
If you run python -m test test_sqlite3, tests would pass because something else sets the mock attribute on unittest. But running only python -m test test_sqlite3.test_cli failed.

import os

from sqlite3.__main__ import main as cli
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy