gh-135444: fix DatagramTransport buffer_size accounting #135445
+53
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
04c6560 to
8a8f749
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Commit 73e8637 added 8 to the buffer_size when send could not be called right away. However, it did not complete this accounting by removing 8 from the buffer size when sending did finally complete.
8a8f749 to
860cec6
Compare
jsbronder
added a commit
to jsbronder/asyncio-dgram
that referenced
this pull request
Jul 7, 2025
Accounting in asyncio.DatagramTransport is broken, so this won't pass. python/cpython#135444 python/cpython#135445
jsbronder
added a commit
to jsbronder/asyncio-dgram
that referenced
this pull request
Jul 7, 2025
Accounting in asyncio.DatagramTransport is broken, so this won't pass. python/cpython#135444 python/cpython#135445
| self.assertEqual(1, len(transport._buffer)) | ||
| self.assertEqual(transport._buffer_size, len(data) + transport._header_size) | ||
|
|
||
| # Now try to send the buffer and let it get requeued |
There was a problem hiding this comment.
Suggested change
| # Now try to send the buffer and let it get requeued | |
| # Now try to send the buffer, it will added to buffer again as if failed |
Comment on lines
+1
to
+2
| Fix asyncio DatagramTransport flow control accounting when a packet cannot | ||
| be immediately sent. |
There was a problem hiding this comment.
Suggested change
| Fix asyncio DatagramTransport flow control accounting when a packet cannot | |
| be immediately sent. | |
| Fix :meth:`asyncio.DatagramTransport.sendto` to account for datagram header size when data cannot be sent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 73e8637 added 8 to the buffer_size when send could not be called right away. However, it did not complete this accounting by removing 8 from the buffer size when sending did finally complete.