Skip to content

gh-102555: Fix comment parsing in HTMLParser #135664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 4, 2025
Merged

gh-102555: Fix comment parsing in HTMLParser #135664

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2706182
gh-135661: Fix comment parsing in HTMLParser
serhiy-storchaka Jun 18, 2025
0e6d20a
Merge branch 'main' into htmlparser-comment
serhiy-storchaka Jun 25, 2025
f1c9efa
Add more tests: "<!---!>" and "<!--!>".
serhiy-storchaka Jun 25, 2025
0f05afc
Move to gh-102555.
serhiy-storchaka Jun 25, 2025
3ec0926
Merge branch 'main' into htmlparser-comment
serhiy-storchaka Jul 3, 2025
b146249
Move to Security.
serhiy-storchaka Jul 3, 2025
c8d9740
Update Misc/NEWS.d/next/Security/2025-06-18-13-28-08.gh-issue-102555.…
serhiy-storchaka Jul 4, 2025
1503ae7
Merge branch 'main' into htmlparser-comment
serhiy-storchaka Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add more tests: "<!---!>" and "<!--!>".
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Jun 25, 2025
commit f1c9efa9bc28093b550bfcb723f627dc8b928b65
4 changes: 4 additions & 0 deletions Lib/test/test_htmlparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,8 @@ def test_comments(self):
'<!----!>'
'<!----!-->'
'<!---- >-->'
'<!---!>-->'
'<!--!>-->'
# nested-comment
'<!-- <!-- nested --> -->'
'<!--<!-->'
Expand All @@ -363,6 +365,8 @@ def test_comments(self):
('comment', ''),
('comment', '--!'),
('comment', '-- >'),
('comment', '-!>'),
('comment', '!>'),
('comment', ' <!-- nested '), ('data', ' -->'),
('comment', '<!'),
('comment', '<!'),
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy