Skip to content

gh-135676: Lexical analysis: Reword String literals and related sections #135942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 23, 2025
Merged

gh-135676: Lexical analysis: Reword String literals and related sections #135942

merged 14 commits into from
Jul 23, 2025

Conversation

encukou
Copy link
Member

@encukou encukou commented Jun 25, 2025 •
edited by github-actions bot
Loading

Hopefully this PR is not too big. I can split it up if that would make it easier to review.

The f-string section is untouched here; a stub is added for t-strings. I'll look at those next.

📚 Documentation preview 📚: https://cpython-previews--135942.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting core review docs Documentation in the Doc dir skip news labels Jun 25, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jun 25, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 25, 2025
Open
@encukou encukou mentioned this pull request Jun 25, 2025
Open
11 tasks
StanFromIreland
StanFromIreland reviewed Jun 25, 2025
View reviewed changes
encukou and others added 2 commits June 25, 2025 16:50
@encukou
Fix ReST errors
9f9d29c
@encukou @StanFromIreland
Update Doc/reference/expressions.rst
11e3731 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
davepeck
davepeck reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@davepeck davepeck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was linked into the PEP 750 documentation TODO list so I took a look. I have one comment as it relates to t-strings; the rest of the changes are broader in scope, so I'll leave it to others to comment. (FWIW, I like the reorganization here!)

@encukou
Copy link
Member Author

encukou commented Jul 9, 2025

@AA-Turner, ping, do you still want to review this?

AA-Turner
AA-Turner approved these changes Jul 23, 2025
View reviewed changes
@encukou encukou enabled auto-merge (squash) July 23, 2025 15:55
@encukou encukou merged commit 777159f into python:main Jul 23, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jul 23, 2025
@AA-Turner AA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 23, 2025
@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2025
@encukou @blaisep
@StanFromIreland @AA-Turner @miss-islington
pythongh-135676: Lexical analysis: Reword String literals and related…
7a1a8cd 
… sections (pythonGH-135942)

(cherry picked from commit 777159f)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Blaise Pabon <blaise@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@miss-islington-app
Copy link

Sorry, @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 777159fa318f39c36ad60039cdf35a8dbb319637 3.13

@bedevere-app
Copy link

bedevere-app bot commented Jul 23, 2025

GH-137048 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 23, 2025
@encukou encukou deleted the lex-analysis-strings branch July 23, 2025 16:08
hugovk pushed a commit that referenced this pull request Jul 23, 2025
@miss-islington @encukou
@blaisep @StanFromIreland @AA-Turner
[3.14] gh-135676: Lexical analysis: Reword String literals and relate…
4832cea 
…d sections (GH-135942) (#137048)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Blaise Pabon <blaise@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Refleaks 3.14 (tier-3) has failed when building commit 4832cea.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1800/builds/367) and take a look at the build logs.
  4. Check if the failure is related to this commit (4832cea) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1800/builds/367

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 830, in gc_collect
    gc.collect()
ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('127.0.0.1', 48354), raddr=('127.0.0.1', 48355)>
Task was destroyed but it is pending!
task: <Task pending name='Task-3613' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x8385dc890>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=10>
k


Traceback (most recent call last):
  File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 830, in gc_collect
    gc.collect()
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('127.0.0.1', 58513), raddr=('127.0.0.1', 58514)>
Task was destroyed but it is pending!
task: <Task pending name='Task-3372' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x841c431d0>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=9>
k


Traceback (most recent call last):
  File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 830, in gc_collect
    gc.collect()
ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('127.0.0.1', 57913), raddr=('127.0.0.1', 57914)>
Task was destroyed but it is pending!
task: <Task pending name='Task-88' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x841c431d0>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=10>
k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davepeck davepeck davepeck left review comments

@StanFromIreland StanFromIreland StanFromIreland left review comments

@AA-Turner AA-Turner AA-Turner approved these changes

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@encukou encukou

Labels
docs Documentation in the Doc dir needs backport to 3.13 bugs and security fixes skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@encukou @bedevere-bot @davepeck @AA-Turner @StanFromIreland
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy