Skip to content

gh-136438: Make sure test_generated_cases pass with all optimization levels #136594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

gh-136438: Make sure test_generated_cases pass with all optimization levels #136594

merged 2 commits into from
Jul 21, 2025

Conversation

efimov-mikhail
Copy link
Contributor

@efimov-mikhail efimov-mikhail commented Jul 12, 2025 •
edited by bedevere-app bot
Loading

Now tests pass with all combinations of -OO and --without-doc-strings.

Before:

======================================================================
FAIL: test_missing_override_failure (test.test_generated_cases.TestGeneratedAbstractCases.test_missing_override_failure)
----------------------------------------------------------------------
AssertionError: 'case OP: {\n            JitOptRef out;\n [104 chars]   }' != ''
- case OP: {
-             JitOptRef out;
-             out = sym_new_not_null(ctx);
-             stack_pointer[-1] = out;
-             break;
-         }


During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/sikko/projects/cpython/Lib/test/test_generated_cases.py", line 2040, in test_missing_override_failure
    with self.assertRaisesRegex(AssertionError, "All abstract uops"):
         ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: "All abstract uops" does not match "'case OP: {\n            JitOptRef out;\n [104 chars]   }' != ''
- case OP: {
-             JitOptRef out;
-             out = sym_new_not_null(ctx);
-             stack_pointer[-1] = out;
-             break;
-         }
"

@bedevere-app bedevere-app bot mentioned this pull request Jul 12, 2025
Open
8 tasks
@efimov-mikhail efimov-mikhail changed the title gh-136438: Make sure test_generated_cases pass with all optimization levels gh-136438: Make sure test_generated_cases pass with all optimization levels Jul 12, 2025
@StanFromIreland StanFromIreland requested a review from sobolevn July 12, 2025 17:12
@efimov-mikhail
Copy link
Contributor Author

Cc @Eclips4

@Eclips4 Eclips4 self-requested a review July 19, 2025 09:18
Eclips4
Eclips4 reviewed Jul 19, 2025
View reviewed changes
Eclips4
Eclips4 reviewed Jul 19, 2025
View reviewed changes
Tools/cases_generator/optimizer_generator.py Outdated
abstract_uop_name in base_uop_names
), f"All abstract uops should override base uops, but {abstract_uop_name} is not."
if abstract_uop_name not in base_uop_names:
raise AssertionError(f"All abstract uops should override base uops, "
Copy link
Member

@Eclips4 Eclips4 Jul 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I'm not sure, from an architectural point of view, that raising AssertionError manually is appropriate. I think we should change it to ValueError and handle it in the tests. WDYM?

Copy link
Contributor Author

@efimov-mikhail efimov-mikhail Jul 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm agree that raising ValueError would be better. My first attempt was just to make as few changes to code as possible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's ok to change it in this PR. Catching an AssertionError is semantically incorrect :)

@efimov-mikhail efimov-mikhail requested a review from Eclips4 July 20, 2025 20:30
@Eclips4 Eclips4 merged commit 58d305c into python:main Jul 21, 2025
48 checks passed
@Eclips4
Copy link
Member

Eclips4 commented Jul 21, 2025

Thank you Mikhail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@sobolevn sobolevn Awaiting requested review from sobolevn

@Eclips4 Eclips4 Awaiting requested review from Eclips4

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efimov-mikhail @Eclips4 @StanFromIreland
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy