Skip to content

gh-136599: Improve long_hash #136600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

gh-136599: Improve long_hash #136600

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
146f5aa
Add test for long_hash
eendebakpt Jul 12, 2025
a162da2
Unroll first digit calculation in long_hash
eendebakpt Jul 12, 2025
4f9fc76
Unroll second digit calculation in long_hash
eendebakpt Jul 12, 2025
07bce4b
whitespace
eendebakpt Jul 12, 2025
32341de
add gh number
eendebakpt Jul 12, 2025
194fb7a
Merge branch 'long_hash' of github.com:eendebakpt/cpython into long_hash
eendebakpt Jul 12, 2025
a48860f
review comments
eendebakpt Jul 13, 2025
6d3754b
fix test on wasi
eendebakpt Jul 13, 2025
fec9fbe
add news entry
eendebakpt Jul 13, 2025
08d7ba9
review comments
eendebakpt Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test for long_hash
  • Loading branch information
@eendebakpt
eendebakpt committed Jul 12, 2025
commit 146f5aa1adb722b28a1a206fc4fc77a29dd28f1a
3 changes: 3 additions & 0 deletions Lib/test/test_long.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1693,5 +1693,8 @@ class MyInt(int):
# GH-117195 -- This shouldn't crash
object.__sizeof__(1)

def test_long_hash(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on introducing hash tests in test_long.py even though there are

cpython/Lib/test/test_builtin.py

Line 1165 in 3dbe02c

def test_hash(self):

and Lib/test/test_hash.py

There are special tests with respect to hashing in many other test modules, e.g.

cpython/Lib/test/test_float.py

Line 635 in 9e5cebd

def test_hash(self):

so IMHO this is a good fit 👍

assert hash(-2**61) != -1

if __name__ == "__main__":
unittest.main()
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy