-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
gh-136728: Refactor build.yml CI config and multissltests.py #136729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WillChilds-Klein
wants to merge
12
commits into
python:main
Choose a base branch
from
WillChilds-Klein:refactor-ssl-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a104f8a
Adapt @hugovk's proof-of-concept CI definition refactor
WillChilds-Klein 3fcbe0d
Preliminary refactor of multissltests.py, TODO migrate to classes
WillChilds-Klein 5d8ec9a
Fix aws-lc/awslc lib name discrepancy
WillChilds-Klein 991c6b2
Migrate AbstractBuilder to abc
WillChilds-Klein 7b51499
Fix imports
WillChilds-Klein 6638127
Complete ABC refactor
WillChilds-Klein 4e0a8ca
Colorize parser
WillChilds-Klein 1a90e0c
Adjust compatibility comment
WillChilds-Klein 1fcb49f
📜🤖 Added by blurb_it.
blurb-it[bot] dd969fb
Revert "📜🤖 Added by blurb_it."
WillChilds-Klein 1edce1c
Merge branch 'main' into refactor-ssl-tests
WillChilds-Klein 3343120
Include old versions when using default versions
WillChilds-Klein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Adjust compatibility comment
- Loading branch information
commit 1a90e0c3414f9c77607658e5a9c5450ea3de05d9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care about Python 3.9 at this point? Frequently for in-tree tools we use python_for_regen as the base version, or the previous stable release (e.g. 3.12 at present).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we care because of security branches I'd say. Also, there are still distros with Pyhton 3.9 as its default I think (I mean, my default Python in OpenSUSE was Python 3.6!). But generally, it's to limit to "simple" Python when possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but e.g. for backports to 3.9 we would run against the version of
Tools/ssl/multissltests.py
in the 3.9 branch? We should add a comment explaining why we care about all non EOL versions, though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's... a good question. I would have said "yes", but now I'm not entirely sure. Maybe not?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah actually, we do:
So for executing the tests, we're really re-using the python interpreter that was used to generate the scripts, so we need to run the tests against the correct interpreter version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WillChilds-Klein could you update
run_python_tests()
in this PR to remove the 3.3 block & use long options to regrtest?-w
->--rerun
&-r
->--randomize