gh-127146: Emscripten: Set umask to zero in test_apropos_empty_doc #136740
Conversation
We think this will fix `test_apropos_empty_doc`.
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 595781e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136740%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
So the test passes with a umask of 077 on native Python but fails with a umask of 077 in Emscripten Python. I will try to understand why. |
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 643e889 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136740%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…-136740) Clears the umask used during a test of pydoc.apropos when testing on Emscripten. This is to work around a known issue in Emscripten; but it's not clear if the chmod call that is causing the problem is actually testing anything of significance. (cherry picked from commit 22af5d3) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
|
GH-136745 is a backport of this pull request to the 3.14 branch. |
…) (#136745) Clears the umask used during a test of pydoc.apropos when testing on Emscripten. This is to work around a known issue in Emscripten; but it's not clear if the chmod call that is causing the problem is actually testing anything of significance. (cherry picked from commit 22af5d3) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
This fixes
test_apropos_empty_doc. Much thanks to @freakboy3742 for the investigation.