Skip to content

gh-135621: Remove dependency on curses from PyREPL #136758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 21, 2025
Merged

gh-135621: Remove dependency on curses from PyREPL #136758

merged 12 commits into from
Jul 21, 2025
+1,230 −161

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Jul 18, 2025 •
edited by bedevere-app bot
Loading

@ambv ambv requested a review from encukou July 18, 2025 14:53
@bedevere-app bedevere-app bot mentioned this pull request Jul 18, 2025
Closed
@ambv
Copy link
Contributor Author

ambv commented Jul 18, 2025

!buildbot

@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 18, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit 58d3e84 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 18, 2025
@ambv
Copy link
Contributor Author

ambv commented Jul 19, 2025

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit 0448edd 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@ambv
Copy link
Contributor Author

ambv commented Jul 19, 2025

!buildbot aarch64 Android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit 0448edd 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge

The command will test the builders whose names match following regular expression: aarch64 Android

The builders matched are:

  • aarch64 Android PR

encukou
encukou reviewed Jul 19, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comments (we had a chat in person):

@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 19, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit 2a053c5 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 19, 2025
@python python deleted a comment from python-cla-bot bot Jul 20, 2025
@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 20, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit d080941 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 20, 2025
@ambv ambv added the needs backport to 3.14 bugs and security fixes label Jul 20, 2025
@ambv ambv merged commit 09dfb50 into python:main Jul 21, 2025
136 checks passed
@miss-islington-app
Copy link

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2025
@ambv @miss-islington
pythongh-135621: Remove dependency on curses from PyREPL (pythonGH-13…
aa91b6f 
…6758)

(cherry picked from commit 09dfb50)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

bedevere-app bot commented Jul 21, 2025

GH-136915 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 21, 2025
@ambv ambv added the sprint label Jul 21, 2025
@encukou encukou mentioned this pull request Jul 21, 2025
Closed
ambv added a commit that referenced this pull request Jul 21, 2025
@miss-islington @ambv
[3.14] gh-135621: Remove dependency on curses from PyREPL (GH-136758) (…
031645a 
…GH-136915)

(cherry picked from commit 09dfb50)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@ambv ambv deleted the gh-135621 branch July 21, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ambv @bedevere-bot @encukou @pablogsal
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy