Skip to content

fix typo in test_ast.py #136767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2025
Merged

fix typo in test_ast.py #136767

merged 2 commits into from
Jul 19, 2025
+1 −1

Conversation

hunterhogan
Copy link
Contributor

No description provided.

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jul 18, 2025
@picnixz picnixz changed the title fix typo in Optimiziation fix typo in test_ast.py Jul 18, 2025
picnixz
picnixz reviewed Jul 18, 2025
View reviewed changes
@picnixz
Copy link
Member

picnixz commented Jul 18, 2025

I'll let @Eclips4 decide whether this should be merged or not but I think it's worth the change and a backport because it influences the filter python -m test test_ast -m *Optimization* for instance.

Eclips4
Eclips4 approved these changes Jul 19, 2025
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label Jul 19, 2025
@Eclips4 Eclips4 merged commit 60146f4 into python:main Jul 19, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks @hunterhogan for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @hunterhogan and @Eclips4, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 60146f4f6f24f37e3bfcb9f101565f6e86cf0146 3.13

@Eclips4
Copy link
Member

Eclips4 commented Jul 19, 2025

@hunterhogan could you please do a backport manually?

@picnixz
Copy link
Member

picnixz commented Jul 19, 2025 •
edited
Loading

Note: it could mean that the test actually doesn't exist in 3.13 or is named differently. If it is the case (and if there is no typo in 3.13 either), no need for a backport (I haven't checked)

@Eclips4
Copy link
Member

Eclips4 commented Jul 19, 2025 •
edited
Loading

Note: it could mean that the test actually doesn't exist in 3.13 or is named differently. If it is the case (and if there is no typo in 3.13 either), no need for a backport (I haven't checked)

I've checked, and ASTOptimiziationTests exists in 3.13, so... the cause must be something else.
(https://github.com/python/cpython/blob/3.13/Lib/test/test_ast/test_ast.py#L3239)

@Eclips4 Eclips4 added the needs backport to 3.14 bugs and security fixes label Jul 19, 2025
@miss-islington-app
Copy link

Thanks @hunterhogan for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2025
@hunterhogan @miss-islington
Fix typo in Lib/test/test_ast/test_ast.py (pythonGH-136767)
7bf0c05 
`ASTOptimiziationTests` -> `ASTOptimizationTests`
(cherry picked from commit 60146f4)

Co-authored-by: Hunter Hogan <hunterhogan@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2025

GH-136783 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 19, 2025
Eclips4 pushed a commit that referenced this pull request Jul 19, 2025
@miss-islington @hunterhogan
[3.14] Fix typo in Lib/test/test_ast/test_ast.py (GH-136767) (#136783)
a91e2bc 
Fix typo in `Lib/test/test_ast/test_ast.py` (GH-136767)

`ASTOptimiziationTests` -> `ASTOptimizationTests`
(cherry picked from commit 60146f4)

Co-authored-by: Hunter Hogan <hunterhogan@users.noreply.github.com>
@hunterhogan hunterhogan deleted the Optimiziation branch July 19, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

Assignees

@Eclips4 Eclips4

Labels
needs backport to 3.13 bugs and security fixes skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hunterhogan @picnixz @Eclips4 @StanFromIreland
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy