gh-136769: Update Fundamental data types table in ctypes.rst #136784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
@AA-Turner, Could you please have a look? #EuroPython2025 |
AA-Turner
approved these changes
Jul 19, 2025
|
Thanks @SZeltaat for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 19, 2025
… types table (pythonGH-136784) Fixed-sized types, like ``c_int32``, are currently missing from the fundamental data types table in the ``ctypes`` documentation. This commit adds them, and notes that ``c_[u]int8`` is an alias of ``c_[u]byte``. (cherry picked from commit acefb97) Co-authored-by: Sina Zel taat <111974143+SZeltaat@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 19, 2025
… types table (pythonGH-136784) Fixed-sized types, like ``c_int32``, are currently missing from the fundamental data types table in the ``ctypes`` documentation. This commit adds them, and notes that ``c_[u]int8`` is an alias of ``c_[u]byte``. (cherry picked from commit acefb97) Co-authored-by: Sina Zel taat <111974143+SZeltaat@users.noreply.github.com>
|
GH-136785 is a backport of this pull request to the 3.14 branch. |
|
GH-136786 is a backport of this pull request to the 3.13 branch. |
skirpichev
approved these changes
Jul 19, 2025
There was a problem hiding this comment.
LGTM
Minor nit: using :c:expr: vs :c:type. I think we should choose something one
PS: a direct link: https://cpython-previews--136784.org.readthedocs.build/en/136784/library/ctypes.html#fundamental-data-types
AA-Turner
pushed a commit
that referenced
this pull request
Jul 19, 2025
…a types table (GH-136784) (#136786) gh-136769: Include fixed-width integers in the fundamental data types table (GH-136784) Fixed-sized types, like ``c_int32``, are currently missing from the fundamental data types table in the ``ctypes`` documentation. This commit adds them, and notes that ``c_[u]int8`` is an alias of ``c_[u]byte``. (cherry picked from commit acefb97) Co-authored-by: Sina Zel taat <111974143+SZeltaat@users.noreply.github.com>
AA-Turner
pushed a commit
that referenced
this pull request
Jul 19, 2025
…a types table (GH-136784) (#136785) gh-136769: Include fixed-width integers in the fundamental data types table (GH-136784) Fixed-sized types, like ``c_int32``, are currently missing from the fundamental data types table in the ``ctypes`` documentation. This commit adds them, and notes that ``c_[u]int8`` is an alias of ``c_[u]byte``. (cherry picked from commit acefb97) Co-authored-by: Sina Zel taat <111974143+SZeltaat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed-sized types, like c_int32 is currently missing from Fundamental data types in the documentation for c types.
This PR adds those types to the table.
Also:
c_int8 and c_unit8 are aliases of c_byte and c_ubyte. The documentation says "Usually as alias for c_byte/c_ubyte", but that can be more explicit. This PR includes this change as well.
📚 Documentation preview 📚: https://cpython-previews--136784.org.readthedocs.build/