gh-73065: Add Date header if missing in smtplib send_message #136850
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Please change the title to use the GitHub issue number. |
| HOST, self.port, local_hostname='localhost', | ||
| timeout=support.LOOPBACK_TIMEOUT) | ||
| self.addCleanup(smtp.close) | ||
| self.assertEqual(smtp.send_message(msg), {}) |
There was a problem hiding this comment.
I am moving these assertions further up so that I can extract the date from the message in order to build the expected string
Misc/NEWS.d/next/Library/2025-07-20-09-51-25.bpo-28879.SLDgcy.rst
Outdated
Show resolved
Hide resolved
|
@Yoav11 A little suggestion, when you complete a suggestion, whether that be by implementing it or providing a reason why you are not going to, please mark the conversation as "Resolved," this keeps the PR more organized. |
| self.assertEqual( | ||
| email.utils.parsedate_to_datetime(date).tzname(), | ||
| "UTC+02:00" | ||
| ) |
There was a problem hiding this comment.
We need to make it work in any timezone
There was a problem hiding this comment.
do you have a suggestion for a specific timezone ? my concern with using something more generic like australia/london etc. is that (although rare) there is some chance that the timezone name or DST conventions change over time which would break the test. As i'm only trying to assert that the user's local was respected in this test, i felt like using something like UTC+02 was less prone to flakiness in the future. But maybe my concern is unfounded, I don't have a ton of expertise with date times :p
|
Please do not use the Update Branch button unless necessary (e.g. fixing conflicts, jogging the CI, or very old PRs) as it uses valuable resources. For more information see the devguide. |
Description
this PR was created during EuroPython 2025 Sprint Weekend.
It builds on #5176 authored by @elafontaine
📚 Documentation preview 📚: https://cpython-previews--136850.org.readthedocs.build/