Skip to content

gh-136854: Exit on error in make venv #136856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2025
Merged

gh-136854: Exit on error in make venv #136856

merged 1 commit into from
Jul 20, 2025

Conversation

nachocab
Copy link
Contributor

@nachocab nachocab commented Jul 20, 2025

@bedevere-app
Copy link

bedevere-app bot commented Jul 20, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

There's a similar Makefile in the PEPs repo, would you like to do the triple?

@hugovk hugovk enabled auto-merge (squash) July 20, 2025 12:07
@hugovk hugovk merged commit 9c2f91c into python:main Jul 20, 2025
41 checks passed
@miss-islington-app
Copy link

Thanks @nachocab for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2025
(cherry picked from commit 9c2f91c)

Co-authored-by: Nacho Caballero <nachocab@gmail.com>
Co-authored-by: Nacho Caballero <nacho.caballero@astrazeneca.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2025
(cherry picked from commit 9c2f91c)

Co-authored-by: Nacho Caballero <nachocab@gmail.com>
Co-authored-by: Nacho Caballero <nacho.caballero@astrazeneca.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 20, 2025

GH-136860 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 20, 2025

GH-136861 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 20, 2025
hugovk pushed a commit that referenced this pull request Jul 20, 2025
Co-authored-by: Nacho Caballero <nachocab@gmail.com>
Co-authored-by: Nacho Caballero <nacho.caballero@astrazeneca.com>
hugovk pushed a commit that referenced this pull request Jul 20, 2025
Co-authored-by: Nacho Caballero <nachocab@gmail.com>
Co-authored-by: Nacho Caballero <nacho.caballero@astrazeneca.com>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 20, 2025
Co-authored-by: Nacho Caballero <nacho.caballero@astrazeneca.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent make venv from saying it succeeded when it failed
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy