bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not None #13688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot None msilib.Directory.start_component() was passing an extra argument to CAB.gen_id().
auvipy
approved these changes
May 31, 2019
|
Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7. |
|
Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-13703 is a backport of this pull request to the 3.6 branch. |
|
GH-13704 is a backport of this pull request to the 2.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 31, 2019
…ot None (pythonGH-13688) msilib.Directory.start_component() was passing an extra argument to CAB.gen_id(). (cherry picked from commit c8d5bf6) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-13705 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 31, 2019
…ot None (pythonGH-13688) msilib.Directory.start_component() was passing an extra argument to CAB.gen_id(). (cherry picked from commit c8d5bf6) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 31, 2019
…ot None (pythonGH-13688) msilib.Directory.start_component() was passing an extra argument to CAB.gen_id(). (cherry picked from commit c8d5bf6) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
This is possibly the cause of the following leak: https://buildbot.python.org/all/#/builders/132/builds/505/steps/4/logs/stdio |
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…ot None (pythonGH-13688) msilib.Directory.start_component() was passing an extra argument to CAB.gen_id().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msilib.Directory.start_component() was passing an extra argument to
CAB.gen_id().
https://bugs.python.org/issue12639