gh-136976: Emscripten: Add _decimal and libmpdec #136979
Closed
+53
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
reviewed
Jul 22, 2025
There was a problem hiding this comment.
It still says on WASI build:
checking for --with-system-libmpdec... yes
checking for libmpdec >= 2.5.0... no
checking for --with-decimal-contextvar... yes
and then
The necessary bits to build these optional modules were not found:
_bz2 _ctypes _decimal
_hashlib _lzma _ssl
_uuid _zstd readline
zlib
|
Well yes, this shouldn't change the wasi build only the Emscripten build. |
|
Closing in favor of #136997 because I accidentally opened this from my main branch. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_decimal,_uuid,_sslor_hashlib#136976