-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
gh-131876: extract _hashlib
helpers into a separate directory
#136995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-131876: extract _hashlib
helpers into a separate directory
#136995
Conversation
_hashlib
helpers into a separate directory_hashlib
helpers into a separate directory
93fdbd3
to
59b0cda
Compare
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 59b0cda 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136995%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
I'll first merge the fortication PR, then merge this one where the macros are rewritten are pure functions when possible. I actually wanted to check whether using an exported function vs a static inline function could change a lot the performance (if possible I don't want to make the code significantly slower because I used non-static inline functions). |
for these code paths I doubt inline even matters. in general these days I assume the compiler will figure that out for static things, at least in pgo and lto builds. |
Actually, I was also a bit worried about the exported symbol. I also try to see if I can just live with Otherwise, I'll use EDIT: everything works well with |
Hum. Windows. Ok I don't know how to correct the project so using |
!buildbot FIPS only |
🤖 New build scheduled with the buildbot fleet by @picnixz for commit a0fa849 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136995%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
I don't think I can backport this as I think it's an ABI change? |
This is a clean rewrite of #135341.
_hashlib
and_hmac
#131876